-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
migrations: add test for importing pull requests in gitea uploader #18752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Loïc Dachary <[email protected]>
Signed-off-by: Loïc Dachary <[email protected]>
lunny
reviewed
Feb 14, 2022
lunny
approved these changes
Feb 14, 2022
Codecov Report
@@ Coverage Diff @@
## main #18752 +/- ##
==========================================
- Coverage 46.64% 46.63% -0.01%
==========================================
Files 846 854 +8
Lines 121331 122516 +1185
==========================================
+ Hits 56595 57136 +541
- Misses 57859 58490 +631
- Partials 6877 6890 +13
Continue to review full report at Codecov.
|
Gusted
reviewed
Feb 22, 2022
Gusted
approved these changes
Feb 23, 2022
make l-g-t-m work |
make l-g-t-m work |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
topic/repo-migration
Migrate repos from other platforms to Gitea, or from Gitea to them
type/testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See original merge request from Loïc Dachary @ forgefriends
The
gitea_uploader.go
is modified in a minimal way to move around 100 lines to theupdateGitForPullRequest
, the code logic is otherwise not modified. Tests are written to provide 100% coverage, except for the system errors fromos.Create
etc.