Skip to content

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 27, 2022

No description provided.

@lunny lunny added type/enhancement An improvement of existing functionality performance/speed performance issues with slow downs labels Feb 27, 2022
@Gusted
Copy link
Contributor

Gusted commented Feb 27, 2022

CI errors are related, test files needs to be updated to the new {Push}MirrorIterate arguments.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 27, 2022
@lunny lunny added this to the 1.17.0 milestone Feb 27, 2022
Copy link
Contributor

@Gusted Gusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean change

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 27, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 28, 2022
@6543 6543 merged commit b75ad7b into go-gitea:main Feb 28, 2022
@lunny lunny deleted the lunny/improve_mirror branch March 1, 2022 01:14
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 1, 2022
* giteaofficial/main:
  [API] Allow removing issues (go-gitea#18879)
  Refactor SecToTime() function (go-gitea#18863)
  Improve mirror iterator (go-gitea#18928)
  Fix login with email panic when email is not exist (go-gitea#18941)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
* Improve mirror iterator

* fix test
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. performance/speed performance issues with slow downs type/enhancement An improvement of existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants