Skip to content

Improved ref comment link when origin is body/title #19741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 18, 2022
Merged

Improved ref comment link when origin is body/title #19741

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1698b92
Makes comments in body text/title return the base page URL instead of…
Eekle May 18, 2022
40c3e86
Merge branch 'main' into comment_url
Eekle May 18, 2022
f17f864
Add comment explaining branch
Eekle May 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion models/issue_xref.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,8 +295,9 @@ func CommentTypeIsRef(t CommentType) bool {

// RefCommentHTMLURL returns the HTML URL for the comment that created this reference
func (comment *Comment) RefCommentHTMLURL() string {
// Edge case for when the reference is inside the title or the description of the referring issue
if comment.RefCommentID == 0 {
return ""
return comment.RefIssueHTMLURL()
}
if err := comment.LoadRefComment(); err != nil { // Silently dropping errors :unamused:
log.Error("LoadRefComment(%d): %v", comment.RefCommentID, err)
Expand Down