Skip to content

Conversation

jonatan5524
Copy link
Contributor

The telegram link URL was parsed with /src/ path and not with /releases/tag, fixed it and its test.

Fixes #19688

@techknowlogick techknowlogick added this to the 1.17.0 milestone May 28, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #19830 (cc01c22) into main (65e0688) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #19830      +/-   ##
==========================================
- Coverage   47.28%   47.27%   -0.01%     
==========================================
  Files         957      957              
  Lines      133346   133346              
==========================================
- Hits        63055    63043      -12     
- Misses      62628    62638      +10     
- Partials     7663     7665       +2     
Impacted Files Coverage Δ
services/webhook/general.go 96.12% <100.00%> (ø)
modules/git/repo_base_nogogit.go 70.58% <0.00%> (-3.93%) ⬇️
modules/git/utils.go 66.29% <0.00%> (-3.38%) ⬇️
modules/queue/queue_bytefifo.go 47.29% <0.00%> (-2.89%) ⬇️
modules/queue/workerpool.go 53.62% <0.00%> (-1.04%) ⬇️
models/issue_comment.go 51.23% <0.00%> (-0.68%) ⬇️
routers/web/repo/view.go 40.48% <0.00%> (+0.48%) ⬆️
models/unit/unit.go 48.71% <0.00%> (+1.70%) ⬆️
modules/queue/queue_channel.go 81.48% <0.00%> (+1.85%) ⬆️
models/asymkey/gpg_key_common.go 56.57% <0.00%> (+3.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65e0688...cc01c22. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 28, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 28, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 28, 2022
@techknowlogick techknowlogick merged commit f2439b7 into go-gitea:main May 28, 2022
@techknowlogick
Copy link
Member

Thanks for the PR :)

zjjhot added a commit to zjjhot/gitea that referenced this pull request May 29, 2022
* giteaofficial/main:
  Fix i18n for Link Account button, re-format tmpl (go-gitea#19835)
  [skip ci] Updated translations via Crowdin
  Adding button to link accounts from user settings (go-gitea#19792)
  fix(telegram): fix link bot to release tag (go-gitea#19830)
  Fix raw endpoint PDF file headers (go-gitea#19825)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
* fix(telegram): fix link bot to release tag

* test(webhook): fix matrixPayload Release

* test(webhook): fix TestTelegramPayload Release
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Telegram hook on the release sends a link to the tag, not to the release
5 participants