Pin Repositories on user page (Fixes #10375) #19831

Eekle · 2022-05-28T19:28:58Z

This PR adds the ability for repository administrators to pin up to 3 repositories to the home page of the repository owner.

This applies to both users and orgs.

Pinned repositories are stored in the user setting pinned_repos.

Not included in this PR:

Any API access to pinning/unpinning
Configurable maximum pinned repos per org/user

models/repo/pin.go

routers/web/repo/repo.go

models/repo_list.go

routers/web/org/home.go

models/repo/pin.go

delvh · 2022-05-28T22:38:42Z

models/repo/pin.go

+	"code.gitea.io/gitea/modules/log"
+)
+
+//Pin Repo or unpin repo


Suggested change

//Pin Repo or unpin repo

// PinRepo or unpin repo

delvh · 2022-05-28T22:40:59Z

models/repo/repo.go

+	err = json.Unmarshal([]byte(pinstring), &pinitems)
+
+	if err != nil {
+		log.Warn("Couldn't deserialise pinned repos: %v", pinstring)


Suggested change

log.Warn("Couldn't deserialise pinned repos: %v", pinstring)

log.Warn("Cannot deserialize pinned repos: %v", err)

Eekle · 2022-05-29T04:52:54Z

@delvh All the bits of logging here are debugging hangovers, they won't be present in the finished PR :)

Thank you for the notes! I'll go through it all today.

Co-authored-by: delvh <[email protected]>

lunny · 2022-05-29T08:18:39Z

Could you give some screenshots about the UI design? I think we need some discuss there.

Eekle · 2022-05-29T08:42:21Z

Could you give some screenshots about the UI design? I think we need some discuss there.

I tried cards above the search bar, but couldn't get it to look coherent.

Part of it is that the repository names can be very long, right? So I found it hard to think of a better presentation than in a list with the rest.

However I take @delvh 's point that these are a user thing and should appear separately to the searched repositories. So I will try again with some cards.

delvh · 2022-05-29T09:02:47Z

I'd say if the name is too long for a card, we can simply overflow,
i.e. really-long-repository-name could be shortened to really-lo..., depending on the width of the card.
That should be easy to achieve with CSS.

EDIT: I just found out that GitHub handles long repository names as follows:

I don't know, do we want to keep that approach, or do we want to use overflow instead?

Eekle · 2022-05-29T11:22:58Z

Moved to a card approach. I know it's not elegant yet but just as a centre for discussion.

models/repo/repo.go

models/user/pin.go

templates/repo/pinned_repos.tmpl

routers/web/org/home.go

models/user/pin.go

templates/org/home.tmpl

Eekle · 2022-05-29T19:27:13Z

Latest UI grab

Co-authored-by: delvh <[email protected]>

… feature/Pinning

Co-authored-by: delvh <[email protected]>

models/user/pin.go

routers/web/org/home.go

templates/org/home.tmpl

templates/repo/pinned_repos.tmpl

Co-authored-by: delvh <[email protected]>

ell1e · 2022-10-15T16:51:22Z

I'm curious since none of the test screenshots are anything close to a phone in portrait mode, but what happens with the pinned repos with a small page width? It would be cool if they then became vertically stacked or something else smart that doesn't involve just a giant horizontal scrollbar (and doesn't involve the pin cards becoming so tiny they can't be read anymore).

In overall this is really cool. Especially on instances with a lot of developers, this can help a lot with finding out what cool stuff the others made.

Eekle · 2022-10-15T18:00:25Z

I'm curious since none of the test screenshots are anything close to a phone in portrait mode, but what happens with the pinned repos with a small page width? It would be cool if they then became vertically stacked or something else smart that doesn't involve just a giant horizontal scrollbar (and doesn't involve the pin cards becoming so tiny they can't be read anymore).

In overall this is really cool. Especially on instances with a lot of developers, this can help a lot with finding out what cool stuff the others made.

I believe stacking vertically is exactly what they do. They use the Fomantic stackable class.

lunny · 2022-10-19T06:59:02Z

models/repo/repo.go

@@ -217,6 +217,20 @@ func (repo *Repository) IsBroken() bool {
 	return repo.Status == RepositoryBroken
 }

+// IsPinned indicates that repository is pinned
+func (repo *Repository) IsPinned() bool {


I think the function should be IsPinned(userID int64). One could pin another public repository?

A repo is either pinned to its owner's profile, or not at all.

This is maybe the same confusion I had with @delvh ? This is not an implementation for pinning any repo you have access to to your profile - it's an implementation for pinning a repo to its owner's profile.

Hm, the most interesting thing I happen to work on is in an org I own, not in my user namespace. So I couldn't pin that then? I'd assume that's a common use case, but maybe that's just me.

It sounds like that's everyone's else's view too. This may need reimplementing with that in mind.

lunny · 2022-10-24T03:35:56Z

Moved to v1.19 because one should pin his organization repositories

Eekle · 2022-10-24T16:56:43Z

I may not have the time to implement this new version any time soon. If someone else is interested I'm happy to hand it over.

So to be clear the spec here is:

Users and orgs should be able to have up to 3 repositories pinned on their profiles
For organisations, this must be repositories within that organisation
For users, it can be any public repository (no restrictions?)

It is not super clear to me what the UI for this will be. For example if I'm on a repository owned by an org for which I'm the administrator, I need the option to pin it to my profile or the org's profile. I don't know how best to do that.

ell1e · 2022-10-24T17:26:18Z

For users, it can be any public repository (no restrictions?)

For what it's worth, I think GitHub restricts it to having either some sort of repo ownership or past contributions.

I'm really just a random user (who happens to like pins), but I personally think no restriction may actually be cooler. It changes pins from only "look at my work" to "hey, look at this cool thing", and that feels more social and dynamic to me. But I wonder what others think?

delvh · 2022-10-25T08:03:11Z

Both have their advantages and disadvantages.
The owner-based approach prevents errors, the freely-pinnable approach is less restrictive.

I'm also fine with both approaches, as long as we can agree on one and keep it at that.

Eekle · 2022-10-26T17:09:06Z

Both have their advantages and disadvantages. The owner-based approach prevents errors, the freely-pinnable approach is less restrictive.

I'm also fine with both approaches, as long as we can agree on one and keep it at that.

I think free pinning gives users the opportunity to use the feature how they wish, which maybe feels more expressive?

Plus it's simpler to implement!

eeyrjmr · 2022-10-26T23:48:10Z

Both have their advantages and disadvantages. The owner-based approach prevents errors, the freely-pinnable approach is less restrictive.
I'm also fine with both approaches, as long as we can agree on one and keep it at that.

I think free pinning gives users the opportunity to use the feature how they wish, which maybe feels more expressive?

Plus it's simpler to implement!

While that is true think about an organisation that wants to bring focus to a key repository. Users pinning for their convenience is important but an organisation pinning for visibility is equally important

eg https://github.com/go-gitea

Eekle · 2022-10-27T05:32:12Z

Both have their advantages and disadvantages. The owner-based approach prevents errors, the freely-pinnable approach is less restrictive.
I'm also fine with both approaches, as long as we can agree on one and keep it at that.

I think free pinning gives users the opportunity to use the feature how they wish, which maybe feels more expressive?
Plus it's simpler to implement!

While that is true think about an organisation that wants to bring focus to a key repository. Users pinning for their convenience is important but an organisation pinning for visibility is equally important

eg https://github.com/go-gitea

I don't understand why users being able to free pin would impact orgs?

Orgs will be able to pin their own repos to their profiles for sure.

delvh · 2022-10-27T08:08:01Z

I am equally confused.
The only thing I can somewhat guess would be that you need a dropdown when pinning to decide where to pin it to, with the options being you, or the orgs you have admin rights in. If you don't have admin rights in any org, we should probably shortcut to directly pinning to your own page.

Eekle · 2022-10-27T08:18:39Z

I am equally confused. The only thing I can somewhat guess would be that you need a dropdown when pinning to decide where to pin it to, with the options being you, or the orgs you have admin rights in. If you don't have admin rights in any org, we should probably shortcut to directly pinning to your own page.

Hold on a mo.

It seems like you're suggesting that orgs should also be able to pin any repository to their profiles - not just ones tha they own?

I thought we were suggesting users could pin anything, but orgs could only pin their own repos.

ell1e · 2022-10-27T08:26:38Z

but orgs could only pin their own repos.

Would that be important to limit though? Maybe it should also be unrestricted.

Eekle · 2022-10-27T08:33:50Z

but orgs could only pin their own repos.

Would that be important to limit though? Maybe it should also be unrestricted.

Yeah that's a fair question. I suppose I'm worried about the UI explosion.

If the dropdown is just:

Pin to my profile
Pin to [orgname]

Then that's pretty digestable. If it's...

Pin to my profile
Pin to [org1]
Pin to [org2]
Pin to [org3]
...

It's a lot more irritating, especially given that 99% of the time you're going to want to pin the repo just to its owning org.

delvh · 2022-10-27T08:34:45Z

Please move the discussion to #10375, I think that's more appropriate as we have a lot to discuss as it seems.

silverwind · 2023-05-30T21:19:24Z

Now that #24406 is in, I assume at least the HTML templates and CSS from it could be re-used here.

hiifong · 2023-07-21T10:35:37Z

Are you still doing this PR?

denyskon · 2023-09-10T10:06:57Z

Closing as stale and the author having said that this feature needs a completely new implementation (#10375 (comment))

Gitea and others added 3 commits May 28, 2022 16:07

Add checks for pinned repositories

e3fe53f

Working pin and unpin in repository.

fa46bfd

Merge branch 'go-gitea:main' into feature/Pinning

11faab0

Eekle marked this pull request as draft May 28, 2022 19:29

delvh reviewed May 28, 2022

View reviewed changes

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 28, 2022

Eekle and others added 3 commits May 29, 2022 06:37

Fixes unpin typo

9f87fd6

Co-authored-by: delvh <[email protected]>

Simplify canPin check

5c22473

Co-authored-by: delvh <[email protected]>

Remove disabled pin button for anons

8464a09

Co-authored-by: delvh <[email protected]>

Refactor based on advice in PR and implement cards

0140a49

delvh reviewed May 29, 2022

View reviewed changes

Working and styled carded pinned repos

30a2076

Gitea and others added 9 commits May 29, 2022 20:30

Revert weird permissions changes

cf5ef19

Set correct initial pinnedRepo capacity

33c5db9

Co-authored-by: delvh <[email protected]>

Move CanPin to services

a0f3148

Merge branch 'feature/Pinning' of https://github.com/Eekle/gitea into…

bfc0a3b

… feature/Pinning

Pin/Unpin takes batch args. Max limit imposed.

b6d4403

Adds better error reporting when too many repos are pinned.

0cfd468

Add signin check to pin button

ef80b11

Co-authored-by: delvh <[email protected]>

Tidier empty array code

ca30e0c

Co-authored-by: delvh <[email protected]>

Merge branch 'go-gitea:main' into feature/Pinning

4e2e304

delvh reviewed May 30, 2022

View reviewed changes

Eekle and others added 2 commits May 30, 2022 10:26

Linter pleasing

d7cc870

Co-authored-by: delvh <[email protected]>

Linter pleasing

2e94d4e

Co-authored-by: delvh <[email protected]>

Apply suggestions from code review - Delvh

b2a7270

Co-authored-by: delvh <[email protected]>

lunny reviewed Oct 19, 2022

View reviewed changes

lunny modified the milestones: 1.18.0, 1.19.0 Oct 24, 2022

delvh mentioned this pull request Oct 27, 2022

Proposal / Feature Request: Pin Repositories #10375

Open

jolheiser modified the milestones: 1.19.0, 1.20.0 Jan 31, 2023

silverwind changed the title ~~Pin Repositories (Fixes #10375)~~ Pin Repositories on user page (Fixes #10375) May 30, 2023

pull-request-size bot added the size/XL label May 30, 2023

delvh removed this from the 1.20.0 milestone Jun 4, 2023

denyskon closed this Sep 10, 2023

eeyrjmr mentioned this pull request Sep 22, 2023

WIP: overhaul profile overview tab UI #27183

Draft

go-gitea locked as resolved and limited conversation to collaborators Dec 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pin Repositories on user page (Fixes #10375) #19831

Pin Repositories on user page (Fixes #10375) #19831

Eekle commented May 28, 2022 •

edited

Loading

delvh May 28, 2022

delvh May 28, 2022

Eekle commented May 29, 2022

lunny commented May 29, 2022

Eekle commented May 29, 2022

delvh commented May 29, 2022 •

edited

Loading

Eekle commented May 29, 2022

Eekle commented May 29, 2022

ell1e commented Oct 15, 2022 •

edited

Loading

Eekle commented Oct 15, 2022

lunny Oct 19, 2022

Eekle Oct 19, 2022

ell1e Oct 19, 2022 •

edited

Loading

Eekle Oct 19, 2022

lunny commented Oct 24, 2022

Eekle commented Oct 24, 2022

ell1e commented Oct 24, 2022 •

edited

Loading

delvh commented Oct 25, 2022

Eekle commented Oct 26, 2022

eeyrjmr commented Oct 26, 2022

Eekle commented Oct 27, 2022

delvh commented Oct 27, 2022

Eekle commented Oct 27, 2022

ell1e commented Oct 27, 2022

Eekle commented Oct 27, 2022

delvh commented Oct 27, 2022

silverwind commented May 30, 2023

hiifong commented Jul 21, 2023

denyskon commented Sep 10, 2023

	log.Warn("Couldn't deserialise pinned repos: %v", pinstring)
	log.Warn("Cannot deserialize pinned repos: %v", err)

Pin Repositories on user page (Fixes #10375) #19831

Pin Repositories on user page (Fixes #10375) #19831

Conversation

Eekle commented May 28, 2022 • edited Loading

delvh May 28, 2022

Choose a reason for hiding this comment

delvh May 28, 2022

Choose a reason for hiding this comment

Eekle commented May 29, 2022

lunny commented May 29, 2022

Eekle commented May 29, 2022

delvh commented May 29, 2022 • edited Loading

Eekle commented May 29, 2022

Eekle commented May 29, 2022

ell1e commented Oct 15, 2022 • edited Loading

Eekle commented Oct 15, 2022

lunny Oct 19, 2022

Choose a reason for hiding this comment

Eekle Oct 19, 2022

Choose a reason for hiding this comment

ell1e Oct 19, 2022 • edited Loading

Choose a reason for hiding this comment

Eekle Oct 19, 2022

Choose a reason for hiding this comment

lunny commented Oct 24, 2022

Eekle commented Oct 24, 2022

ell1e commented Oct 24, 2022 • edited Loading

delvh commented Oct 25, 2022

Eekle commented Oct 26, 2022

eeyrjmr commented Oct 26, 2022

Eekle commented Oct 27, 2022

delvh commented Oct 27, 2022

Eekle commented Oct 27, 2022

ell1e commented Oct 27, 2022

Eekle commented Oct 27, 2022

delvh commented Oct 27, 2022

silverwind commented May 30, 2023

hiifong commented Jul 21, 2023

denyskon commented Sep 10, 2023

Eekle commented May 28, 2022 •

edited

Loading

delvh commented May 29, 2022 •

edited

Loading

ell1e commented Oct 15, 2022 •

edited

Loading

ell1e Oct 19, 2022 •

edited

Loading

ell1e commented Oct 24, 2022 •

edited

Loading