Skip to content

Release page show all tags in compare dropdown (#20070) #20072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Release page show all tags in compare dropdown (#20070) #20072

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4666d5
Release page show all tags in compare dropdown (#20070)
6543 Jun 21, 2022
b89e60e
code-style nits
6543 Jun 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion routers/web/repo/release.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,14 @@ func releasesOrTags(ctx *context.Context, isTagList bool) {
listOptions.PageSize = setting.API.MaxResponseItems
}

tags, err := ctx.Repo.GitRepo.GetTags(listOptions.GetStartEnd())
// TODO(20073) tags are used for compare feature witch needs all tags
// filtering is doen at the client side atm
tagListStart, tagListEnd := 0, 0
if isTagList {
tagListStart, tagListEnd = listOptions.GetStartEnd()
}

tags, err := ctx.Repo.GitRepo.GetTags(tagListStart, tagListEnd)
if err != nil {
ctx.ServerError("GetTags", err)
return
Expand Down