Skip to content

Use body text color in repository files table links #20386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 22, 2022
+17 −11
Merged

Use body text color in repository files table links #20386

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4a6b618
Use body text color in #repo-files-table links
lhsazevedo Jul 16, 2022
515354b
Save a selector by using .muted
lhsazevedo Jul 16, 2022
8b04e0d
Improve contrast of file list message and age
lhsazevedo Jul 16, 2022
2475d5e
Avoid :not by targeting .default-link instead
lhsazevedo Jul 16, 2022
ac6ee52
Fix hover state and save more selectors
lhsazevedo Jul 17, 2022
acf0ad4
Mute submodule name
lhsazevedo Jul 19, 2022
bf8c567
Merge branch 'main' into repo-files-color
wxiaoguang Jul 20, 2022
051c937
Merge branch 'main' into repo-files-color
lafriks Jul 21, 2022
d372272
Merge branch 'main' into repo-files-color
wxiaoguang Jul 22, 2022
7b4060f
Merge branch 'main' into repo-files-color
wxiaoguang Jul 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/markup/html.go
View file
Original file line number Diff line number Diff line change
@@ -1176,7 +1176,7 @@ func genDefaultLinkProcessor(defaultLink string) processor {
node.DataAtom = atom.A
node.Attr = []html.Attribute{
{Key: "href", Val: defaultLink},
{Key: "class", Val: "default-link"},
{Key: "class", Val: "default-link muted"},
}
node.FirstChild, node.LastChild = ch, ch
}
12 changes: 6 additions & 6 deletions templates/repo/view_list.tmpl
View file
Original file line number Diff line number Diff line change
@@ -8,9 +8,9 @@
{{if .LatestCommitUser}}
{{avatar .LatestCommitUser 24}}
{{if .LatestCommitUser.FullName}}
<a href="{{.LatestCommitUser.HomeLink}}"><strong>{{.LatestCommitUser.FullName}}</strong></a>
<a class="muted" href="{{.LatestCommitUser.HomeLink}}"><strong>{{.LatestCommitUser.FullName}}</strong></a>
{{else}}
<a href="{{.LatestCommitUser.HomeLink}}"><strong>{{if .LatestCommit.Author}}{{.LatestCommit.Author.Name}}{{else}}{{.LatestCommitUser.Name}}{{end}}</strong></a>
<a class="muted" href="{{.LatestCommitUser.HomeLink}}"><strong>{{if .LatestCommit.Author}}{{.LatestCommit.Author.Name}}{{else}}{{.LatestCommitUser.Name}}{{end}}</strong></a>
{{end}}
{{else}}
{{if .LatestCommit.Author}}
@@ -54,7 +54,7 @@
{{svg "octicon-file-submodule"}}
{{$refURL := $subModuleFile.RefURL AppUrl $.Repository.FullName $.SSHDomain}}
{{if $refURL}}
<a href="{{$refURL}}">{{$entry.Name}}</a><span class="at">@</span><a href="{{$refURL}}/commit/{{PathEscape $subModuleFile.RefID}}">{{ShortSha $subModuleFile.RefID}}</a>
<a class="muted" href="{{$refURL}}">{{$entry.Name}}</a><span class="at">@</span><a href="{{$refURL}}/commit/{{PathEscape $subModuleFile.RefID}}">{{ShortSha $subModuleFile.RefID}}</a>
{{else}}
{{$entry.Name}}<span class="at">@</span>{{ShortSha $subModuleFile.RefID}}
{{end}}
@@ -63,16 +63,16 @@
{{$subJumpablePathName := $entry.GetSubJumpablePathName}}
{{$subJumpablePath := SubJumpablePath $subJumpablePathName}}
{{svg "octicon-file-directory-fill"}}
<a href="{{$.TreeLink}}/{{PathEscapeSegments $subJumpablePathName}}" title="{{$subJumpablePathName}}">
<a class="muted" href="{{$.TreeLink}}/{{PathEscapeSegments $subJumpablePathName}}" title="{{$subJumpablePathName}}">
{{if eq (len $subJumpablePath) 2}}
<span class="jumpable-path">{{index $subJumpablePath 0}}</span>{{index $subJumpablePath 1}}
<span class="color-text-light-2">{{index $subJumpablePath 0}}</span>{{index $subJumpablePath 1}}
{{else}}
{{index $subJumpablePath 0}}
{{end}}
</a>
{{else}}
{{svg (printf "octicon-%s" (EntryIcon $entry))}}
<a href="{{$.TreeLink}}/{{PathEscapeSegments $entry.Name}}" title="{{$entry.Name}}">{{$entry.Name}}</a>
<a class="muted" href="{{$.TreeLink}}/{{PathEscapeSegments $entry.Name}}" title="{{$entry.Name}}">{{$entry.Name}}</a>
{{end}}
{{end}}
</span>
6 changes: 6 additions & 0 deletions web_src/less/_base.less
View file
Original file line number Diff line number Diff line change
@@ -118,6 +118,7 @@
--color-text-dark: #080808;
--color-text: #212121;
--color-text-light: #555555;
--color-text-light-1: #6a6a6a;
--color-text-light-2: #808080;
--color-text-light-3: #a0a0a0;
--color-box-header: #f7f7f7;
@@ -275,6 +276,7 @@ a.muted {

a:hover,
a.muted:hover,
a.muted:hover [class*="color-text"],
.ui.breadcrumb a:hover {
color: var(--color-primary);
}
@@ -2206,3 +2208,7 @@ table th[data-sortt-desc] {
}
}
}

.color-text-light-2 {
color: var(--color-text-light-2);
}
7 changes: 3 additions & 4 deletions web_src/less/_repository.less
View file
Original file line number Diff line number Diff line change
@@ -367,6 +367,8 @@
}

&.message {
color: var(--color-text-light-1);

@media @mediaXl {
max-width: 400px;
}
@@ -381,6 +383,7 @@

&.age {
width: 120px;
color: var(--color-text-light-1);
}

.truncate {
@@ -432,10 +435,6 @@
padding-bottom: 8px;
width: calc(100% - 1.25rem);
}

.jumpable-path {
color: var(--color-text-light-2);
}
}

.non-diff-file-content {
1 change: 1 addition & 0 deletions web_src/less/themes/theme-arc-green.less
View file
Original file line number Diff line number Diff line change
@@ -98,6 +98,7 @@
--color-text-dark: #dbe0ea;
--color-text: #bbc0ca;
--color-text-light: #a6aab5;
--color-text-light-1: #979ba6;
--color-text-light-2: #8a8e99;
--color-text-light-3: #707687;
--color-footer: #2e323e;