Go 1.19 format #20758
Merged
Go 1.19 format #20758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jolheiser <[email protected]>
Signed-off-by: jolheiser <[email protected]>
jolheiser
added
topic/code-linting
skip-changelog
jolheiser
commented
Aug 11, 2022
GiteaBot
added
the
lgtm/need 2
wxiaoguang
approved these changes
Aug 11, 2022
There was a problem hiding this comment.
Small hint: comparing with hiding space makes the diff clearer. 😁
https://github.com/go-gitea/gitea/pull/20758/files?diff=unified&w=1
Update: CI failure is related to swagger, waiting for upstream, added a blocked label
GiteaBot
added
lgtm/need 1
6543
reviewed
Aug 11, 2022
wxiaoguang
added
the
status/blocked
KN4CK3R
reviewed
Aug 11, 2022
zeripath
reviewed
Aug 13, 2022
Co-authored-by: zeripath <[email protected]>
Signed-off-by: jolheiser <[email protected]>
|
go-swagger/go-swagger#2808 got merged & tagged (v0.30.0) |
6543
approved these changes
Aug 30, 2022
GiteaBot
added
lgtm/done
6543
removed
the
status/blocked
lafriks
approved these changes
Aug 31, 2022
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 31, 2022
* upstream/main: Go 1.19 format (go-gitea#20758) [skip ci] Updated translations via Crowdin
wxiaoguang
added a commit
that referenced
this pull request
Sep 22, 2022
The images used by Gitea's drone pipeline were upgraded to Go 1.19.x It causes the lint fails because Go 1.19 uses new code format. This PR partially backport #20758 (including the emoji-data sync), partially fix the format manually.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Go 1.19, doc comments have been enhanced and
gofmtnow formats them to be clearer.Thankfully, for the most part it's backwards compatible. That is, I formatted using a local 1.19, then when re-running
make fmtusing 1.18 there were no further changes.Therefore, I think this PR should fix cases where contributors have 1.19 locally and thus
make fmtwould cause unwanted noise in their PR.The one place in our codebase that seemed to behave differently was in our CSV test where I replaced a literal tab with
\t, which is treated the same within the test and worked with the formatter on both versions.