Fix tooltip init after review #20814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous code passed a jQuery collection which initTooltip couldn't handle. Instead, iterate the individial matched elements and add a dollar to the variable name to make it clear it's jQuery. Fixes: go-gitea#20809
Gusted
approved these changes
Aug 16, 2022
GiteaBot
added
the
lgtm/need 1
|
I also renamed |
lafriks
approved these changes
Aug 16, 2022
GiteaBot
added
lgtm/done
lunny
added
the
skip-changelog
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 17, 2022
* giteaofficial/main: Add proxy host into allow list (go-gitea#20798) Fix tooltip init after review (go-gitea#20814)
vsysoev
pushed a commit
to IntegraSDL/gitea
that referenced
this pull request
Aug 28, 2022
* Fix tooltip init after review Previous code passed a jQuery collection which initTooltip couldn't handle. Instead, iterate the individial matched elements and add a dollar to the variable name to make it clear it's jQuery. Fixes: go-gitea#20809
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous code passed a jQuery collection which
initTooltipcouldn't handle. Instead, iterate the individial matched elements and add a dollar to the variable name to make it clear it's jQuery.Fixes: #20809