Skip to content

Fix exit status 1 not handled @ getMergeCommit #2087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2017
Merged

Fix exit status 1 not handled @ getMergeCommit #2087

merged 1 commit into from
Jun 30, 2017

Conversation

Bwko
Copy link
Member

@Bwko Bwko commented Jun 30, 2017

process.GetManager().ExecDirEnv returns an error in the form of exec(%d:%s) failed: %v stdout: %v stderr: %v. Because of that the error code comparison fails.

@Bwko Bwko force-pushed the fix_error_exit branch from 0bf6f7f to b36849d Compare June 30, 2017 10:35
@lafriks
Copy link
Member

lafriks commented Jun 30, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 30, 2017
@cez81
Copy link
Contributor

cez81 commented Jun 30, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 30, 2017
@lafriks lafriks merged commit 12cb6cd into go-gitea:master Jun 30, 2017
@Bwko Bwko deleted the fix_error_exit branch June 30, 2017 13:08
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Bwko @lafriks @cez81 @tboerger