Skip to content

On Tag/Branch Exist Check, dont panic if repo is nil (#21787) #21789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 5, 2022
Merged

On Tag/Branch Exist Check, dont panic if repo is nil (#21787) #21789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
162ab32
On Tag/Branch Exist Check, dont panic if repo is nil
6543 Nov 12, 2022
32f0d45
Merge branch 'release/v1.17' into dont-panic
lunny Dec 4, 2022
2469412
Merge branch 'release/v1.17' into dont-panic
lafriks Dec 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/git/repo_branch_nogogit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ func (repo *Repository) IsReferenceExist(name string) bool {

// IsBranchExist returns true if given branch exists in current repository.
func (repo *Repository) IsBranchExist(name string) bool {
if name == "" {
if repo == nil || name == "" {
return false
}

Expand Down
2 changes: 1 addition & 1 deletion modules/git/repo_tag_nogogit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import (

// IsTagExist returns true if given tag exists in the repository.
func (repo *Repository) IsTagExist(name string) bool {
if name == "" {
if repo == nil || name == "" {
return false
}

Expand Down