Do not emit ambiguous character warning on rendered pages (#22016) #22018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2016) Backport go-gitea#22016 The real sensitivity of ambiguous characters is in source code - therefore warning about them in rendered pages causes too many warnings. Therefore simply remove the warning on rendered pages. The escape button will remain available and it is present on the view source page. Fix go-gitea#20999 Signed-off-by: Andrew Thornton <[email protected]>
lunny
approved these changes
Dec 4, 2022
GiteaBot
added
the
lgtm/need 1
silverwind
approved these changes
Dec 4, 2022
GiteaBot
added
lgtm/done
|
This should also affect rendered pages in wikis, correct? I'm asking because I still see the warning on wiki pages in codeberg, but maybe this hasn't made it's way into the live codeberg instance yet. |
|
Please open a new issue. This change probably missed the Wiki renderings. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #22016
The real sensitivity of ambiguous characters is in source code - therefore warning about them in rendered pages causes too many warnings. Therefore simply remove the warning on rendered pages.
The escape button will remain available and it is present on the view source page.
Fix #20999
Signed-off-by: Andrew Thornton [email protected]