-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Mask access token in migration forms #22232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Questions:
|
Is this still a draft? |
Forgot this PR. Will check out the emoji issue. |
Actually, let's close this in favor of #22175, the firefox workaround is too much of a hack. Proper solution should be |
Mask the field without the downsides of
type=password
. It might be argued that there should be a "reveal" button, but this is too tricky to implement and I see that as the job of the browser, and I guess some mobile ones will provide such a button. Also, disable autocomplete so these tokens do not end up in form history.Fixes: #22174
Fixes: #22175
Firefox:

Chrome:
