Skip to content

Fix PR file tree folders no longer collapsing #22864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 12, 2023
Merged

Fix PR file tree folders no longer collapsing #22864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cfb4048
fix click handler for collapsing folders and prevent accidental selec…
gempir Feb 11, 2023
a73b8cf
color diff detail stats
gempir Feb 11, 2023
32d16dc
add colors to file names
gempir Feb 11, 2023
b6b0ce9
less colorful
gempir Feb 11, 2023
df1cdcc
style with muted instead and add a comment
gempir Feb 11, 2023
ab887b3
Merge branch 'main' into foldable-folders
zeripath Feb 11, 2023
4726608
Merge branch 'main' into foldable-folders
lunny Feb 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions web_src/js/components/DiffFileTreeItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
/>
<a
v-if="item.isFile"
class="file ellipsis"
class="file ellipsis muted"
:href="item.isFile ? '#diff-' + item.file.NameHash : ''"
>{{ item.name }}</a>
<SvgIcon
Expand Down Expand Up @@ -63,7 +63,7 @@ export default {
if (itemIsFile) {
return;
}
this.$set(this, 'collapsed', !this.collapsed);
this.collapsed = !this.collapsed;
},
getIconForDiffType(pType) {
const diffTypes = {
Expand All @@ -83,6 +83,7 @@ export default {
span.svg-icon.status {
float: right;
}

span.svg-icon.file {
color: var(--color-secondary-dark-7);
}
Expand Down Expand Up @@ -122,6 +123,8 @@ span.svg-icon.octicon-diff-renamed {
div.directory {
display: grid;
grid-template-columns: 18px 20px auto;
user-select: none;
cursor: pointer;
}

div.directory:hover {
Expand Down
14 changes: 14 additions & 0 deletions web_src/less/_repository.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1614,6 +1614,20 @@
margin-right: .25rem;
}

// Because the translations contain the <strong> we need to style with nth-of-type

.diff-detail-stats strong:nth-of-type(1) {
color: var(--color-yellow);
}

.diff-detail-stats strong:nth-of-type(2) {
color: var(--color-green);
}

.diff-detail-stats strong:nth-of-type(3) {
color: var(--color-red);
}

.diff-detail-stats {
@media (max-width: 480px) {
font-size: 0;
Expand Down