Remember to attach the parent tree when converting TreeEntry() -> Tree() #22902
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
!fixup go-gitea#22177 The only place this function is used so far is in findReadmeFileInEntries(), so the only visible effect of this oversight was in an obscure corner: if the README was in a subfolder and was a symlink that pointed up, as in .github/README.md -> ../docs/old/setup.md, the README would fail to render when because FollowLinks() hit the nil ptree.
GiteaBot
added
the
lgtm/need 2
lunny
added
type/bug
issue/regression
lunny
approved these changes
Feb 14, 2023
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
Feb 14, 2023
GiteaBot
added
lgtm/done
|
please update with base branch |
techknowlogick
added
the
reviewed/wait-merge
|
make lgtm done |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 15, 2023
* upstream/main: Add command to bulk set must-change-password (go-gitea#22823) Remember to attach the parent tree when converting TreeEntry() -> Tree() (go-gitea#22902) Fix dark-colored description text in arc-green theme (go-gitea#22908) Fix the full-height problem for all pages (go-gitea#22905) Remove Fomantic-UI's `.hidden` CSS class for menu elements (go-gitea#22895)
lunny
removed
the
reviewed/wait-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!fixup #22177
The only place this function is used so far is in findReadmeFileInEntries(), so the only visible effect of this oversight was in an obscure README-related corner: if the README was in a subfolder and was a symlink that pointed up, as in .github/README.md -> ../docs/old/setup.md, the README would fail to render when FollowLinks() hit the nil ptree. This makes the ptree non-nil and thus repairs it.