Skip to content

Add aria attributes to interactive time tooltips. #23661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 24, 2023
Merged

Add aria attributes to interactive time tooltips. #23661

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a5c09d5
Add aria attributes to interactive time tooltips. Fixes #23645.
fsologureng Mar 23, 2023
10c6bf9
Merge branch 'main' into a11y-tippy-aria
zeripath Mar 23, 2023
3efa6f6
Merge branch 'main' into a11y-tippy-aria
techknowlogick Mar 24, 2023
4f01085
Merge branch 'main' into a11y-tippy-aria
lunny Mar 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web_src/js/modules/tippy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ function attachTooltip(target, content = null) {
delay: 100,
role: 'tooltip',
placement: target.getAttribute('data-tooltip-placement') || 'top-start',
...(target.getAttribute('data-tooltip-interactive') === 'true' ? {interactive: true} : {}),
...(target.getAttribute('data-tooltip-interactive') === 'true' ? {interactive: true, aria: {content: 'describedby', expanded: false}} : {}),
};

if (!target._tippy) {
Expand Down