New commits list #24423
New commits list #24423
Conversation
GiteaBot
added
the
lgtm/need 2
silverwind
added
type/enhancement
|
I will also re-work the commit badge, likely removing the "fancy" styling around it and just use icons to indicate signature. Part of the styling for it is unfortunately shared with last commit in file table, so extensive refactoring will be required to decouple those two ways of displaying a commit. |
|
I think line dividers are still needed. |
| <div class="ui attached table segment commits-list"> | ||
| {{$commitRepoLink := $.RepoLink}}{{if $.CommitRepoLink}}{{$commitRepoLink = $.CommitRepoLink}}{{end}} | ||
| {{range .Commits}} | ||
| <div class="commits-list-row gt-df gt-ac gt-px-4 gt-py-2"> |
There was a problem hiding this comment.
These "gt-df gt-ac gt-px-4 gt-py-2" seems quite wordy.
Since it has a class commits-list-row, is it better to put the styles on the particular CSS class name?
There was a problem hiding this comment.
As mentioned in the other issue, I think what can be done with helper classes should be done with them. I see CSS currently only for stuff that can not be done with helper classes.
Another benefit of helper classes is that they move when the element moves, so won't leave garbage CSS during refactoring.
I do like to retain descriptive class names, primarily as a visual aid for reading the code.
There was a problem hiding this comment.
I think what can be done with helper classes should be done with them.
Totally agree. It helps when working on other people's code.
I do like to retain descriptive class names, primarily as a visual aid for reading the code.
Interesting idea. I'll give that a try,
Make this stylelint rule match on more properties. The dead CSS relates to the navbar, which currently has classes: ``` ui top secondary stackable main menu following bar light ``` Which means `.following.bar .top.menu` can never match, so remove this dead CSS as well as inactive `z-index` and `left` on it. Commits table striping becomes more visible on dark theme, but I don't think it's worth introducing a new color until #24423 is ready, which would have to remove it again: <img width="668" alt="Screenshot 2023-05-01 at 18 41 49" src="https://user-images.githubusercontent.com/115237/235489873-6b272899-1d78-443a-872c-ee7731c269f9.png"> <img width="680" alt="Screenshot 2023-05-01 at 18 41 41" src="https://user-images.githubusercontent.com/115237/235489878-1b9468af-c74f-48a6-a469-9eba57cfcb4d.png">
|
Will it ever get ready for review? |
|
Maybe. It is pretty high on my list of things to do. |
|
I think I'll first split out a PR that moves or removes the overly prominent styling of commits hashes, e.g. green/yellow/red for signature level. I think we should definitely subtemplate these which in turn will make the commit list implementation much simpler. |
|
Not going to continue here, maybe later in a different PR, but anyone can feel free to pick this up in the meanwhile. |
Very early WIP: