feat: implement organization secret creation API #26566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
- Add a new `CreateSecretOption` struct for creating secrets
- Implement a `CreateOrgSecret` function to create a secret in an organization
- Add a new route in `api.go` to handle the creation of organization secrets
- Update the Swagger template to include the new `CreateOrgSecret` API endpoint
- Change the `basePath` in the Swagger template from `{{AppSubUrl | JSEscape | Safe}}/api/v1` to `/api/v1`
Signed-off-by: appleboy <[email protected]>
- Add an `ID` field to the `Secret` struct in `secret.go` - Import the `convert` service in `action.go` - Modify the `CreateOrgSecret` function in `action.go` to use the `convert` service and return a JSON response - Create a new file `secret.go` in the `convert` service - Implement a `ToSecret` function in the new `secret.go` file to convert a `Secret` to API format Signed-off-by: appleboy <[email protected]>
Signed-off-by: appleboy <[email protected]>
- Add `swaggerResponseSecret` struct to `action.go` - Add `swaggerResponseSecret` struct to `action.go` - Add `CreateSecretOption` struct to `options.go` - Modify `basePath` value in `v1_json.tmpl` Signed-off-by: Bo-Yi Wu <[email protected]>
appleboy
changed the title
Signed-off-by: Bo-Yi Wu <[email protected]>
Signed-off-by: Bo-Yi Wu <[email protected]>
wolfogre
approved these changes
Aug 21, 2023
GiteaBot
added
lgtm/need 1
lunny
reviewed
Aug 21, 2023
- Remove the `ID` field from the `Secret` struct in `modules/structs/secret.go` - Remove the `id` field from the Swagger template in `templates/swagger/v1_json.tmpl` Signed-off-by: Bo-Yi Wu <[email protected]>
…vert/secret.go` - Remove the `ID` field from the `ToSecret` function in `services/convert/secret.go` Signed-off-by: Bo-Yi Wu <[email protected]>
lunny
approved these changes
Aug 22, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 22, 2023
* upstream/main: Improve show role (go-gitea#26621) Improve some flex layouts (go-gitea#26649) feat: implement organization secret creation API (go-gitea#26566) Check disabled workflow when rerun jobs (go-gitea#26535)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CreateSecretOptionstruct for creating secretsCreateOrgSecretfunction to create a secret in an organizationapi.goto handle the creation of organization secretsCreateOrgSecretAPI endpoint