Skip to content

Remove CSS has selector and improve various styles #26891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2023
Merged

Remove CSS has selector and improve various styles #26891

merged 2 commits into from
Sep 4, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Sep 4, 2023 •
edited
Loading

Replace #26850

Major changes:

  1. Remove all has selectors, it is still not supported by firefox. Actually there could be some more general and clearer approaches
  2. Remove two-toggle-buttons, the .ui.buttons just works well
  3. Rewrite the .ui.buttons border styles, see the screenshots
  4. Remove the "fine-tuning" paddings from the the flex children, they could layout themselves well.

image

image

image

image

@wxiaoguang wxiaoguang added topic/ui Change the appearance of the Gitea UI type/refactoring Existing code has been cleaned up. There should be no new functionality. labels Sep 4, 2023
@wxiaoguang wxiaoguang added this to the 1.21.0 milestone Sep 4, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 4, 2023
@wxiaoguang wxiaoguang mentioned this pull request Sep 4, 2023
Closed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 4, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 4, 2023
@lunny lunny merged commit 51cfe0e into go-gitea:main Sep 4, 2023
@wxiaoguang wxiaoguang deleted the fix-css-has branch September 4, 2023 10:54
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 5, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
cefe080 
* giteaofficial/main:
  Move mail notification logic to service layer (go-gitea#26905)
  Improve DeleteByID (go-gitea#26904)
  Update backup instructions to align with archive structure (go-gitea#26902)
  More fixes for the "commit-body" (go-gitea#26898)
  Show queue's active worker number (go-gitea#26896)
  Remove CSS `has` selector and improve various styles (go-gitea#26891)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @delvh @GiteaBot