Skip to content

Don't use subselect in DeleteIssuesByRepoID (#27332) #27408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2023
Merged

Don't use subselect in DeleteIssuesByRepoID (#27332) #27408

merged 1 commit into from
Oct 3, 2023

Conversation

GiteaBot
Copy link
Collaborator

@GiteaBot GiteaBot commented Oct 3, 2023

Backport #27332 by @JakobDev

Part of https://codeberg.org/forgejo/discussions/issues/61

This is workaround for a bug in MariaDB

@GiteaBot GiteaBot added type/refactoring Existing code has been cleaned up. There should be no new functionality. performance/speed performance issues with slow downs lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 3, 2023
@GiteaBot GiteaBot added this to the 1.21.0 milestone Oct 3, 2023
@GiteaBot GiteaBot requested review from lunny and puni9869 October 3, 2023 08:17
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 3, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 3, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 3, 2023
@lunny lunny merged commit d5da0e6 into go-gitea:release/v1.21 Oct 3, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 3, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@puni9869 puni9869 puni9869 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. performance/speed performance issues with slow downs type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@GiteaBot @lunny @puni9869 @JakobDev