Fix attachment download bug #27486
Merged
Fix attachment download bug #27486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
type/bug
backport/v1.20
GiteaBot
added
the
lgtm/need 2
delvh
reviewed
Oct 8, 2023
| @@ -16,12 +13,7 @@ func WebAssetDownloadURL(repo *repo_model.Repository, attach *repo_model.Attachm | |||
| } | |||
|
|
|||
| func APIAssetDownloadURL(repo *repo_model.Repository, attach *repo_model.Attachment) string { | |||
There was a problem hiding this comment.
Do we even need the repo param anymore now?
There was a problem hiding this comment.
I think these function could be removed. To keep this PR small, I need another refactor PR to do that.
delvh
approved these changes
Oct 9, 2023
GiteaBot
added
lgtm/need 1
silverwind
approved these changes
Oct 9, 2023
GiteaBot
added
lgtm/done
wxiaoguang
reviewed
Oct 9, 2023
| } | ||
|
|
||
| // /repos/{owner}/{repo}/releases/{id}/assets/{attachment_id} | ||
| return setting.AppURL + "api/repos/" + repo.FullName() + "/releases/" + strconv.FormatInt(attach.ReleaseID, 10) + "/assets/" + strconv.FormatInt(attach.ID, 10) |
There was a problem hiding this comment.
What would happen to setting.AppURL + "api/repos/" + repo.FullName() + "/releases/" + strconv.FormatInt(attach.ReleaseID, 10) + "/assets/" + strconv.FormatInt(attach.ID, 10) ?
Should this handler be removed?
There was a problem hiding this comment.
Since it has been released, maybe deprecated is better.
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Oct 10, 2023
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Oct 10, 2023
silverwind
pushed a commit
that referenced
this pull request
Oct 11, 2023
Backport #27486 by @lunny Fix #27204 This PR allows `/<username>/<reponame>/attachments/<uuid>` access with personal access token and also changed attachments API download url to it so it can be download correctly. Co-authored-by: Lunny Xiao <[email protected]>
silverwind
pushed a commit
that referenced
this pull request
Oct 11, 2023
Backport #27486 by @lunny Fix #27204 This PR allows `/<username>/<reponame>/attachments/<uuid>` access with personal access token and also changed attachments API download url to it so it can be download correctly. Co-authored-by: Lunny Xiao <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Oct 11, 2023
* giteaofficial/main: [skip ci] Updated translations via Crowdin Fix attachment download bug (go-gitea#27486) Make actions default enabled for newly created repository if global configuraion enabled (go-gitea#27482) Fix the wrong HTTP response status code for duplicate packages (go-gitea#27480) Increase queue length (go-gitea#27555)
|
I was unable to create a backport for 1.20. @lunny, please send one manually. 🍵 |
GiteaBot
added
the
backport/manual
|
I was unable to create a backport for 1.21. @lunny, please send one manually. 🍵 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #27204
This PR allows
/<username>/<reponame>/attachments/<uuid>access with personal access token and also changed attachments API download url to it so it can be download correctly.