Apply tailwindcss rules with !important
#29437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
silverwind
added
the
skip-changelog
techknowlogick
approved these changes
Feb 27, 2024
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Feb 27, 2024
wxiaoguang
approved these changes
Feb 27, 2024
GiteaBot
added
lgtm/done
Co-authored-by: wxiaoguang <[email protected]>
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
|
Isn't it changed and merged too fast? I think we should wait for silverwind to confirm whether they likes or would like to improve the comment, just wait for several hours. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion in #29423, I think this is the right way that does not burden developers having to think about CSS precedence which should be irrelevant with a atomic CSS framework.