Skip to content

Fix issue link does not support quotes (#29484) #29487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 2, 2024
Merged

Fix issue link does not support quotes (#29484) #29487

merged 5 commits into from
Mar 2, 2024

Conversation

charles7668
Copy link
Contributor

@charles7668 charles7668 commented Feb 29, 2024 •
edited
Loading

Close #29484

圖片

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 29, 2024
@lunny
Copy link
Member

lunny commented Feb 29, 2024

Please add some tests

@lunny lunny added type/bug backport/v1.21 This PR should be backported to Gitea 1.21 labels Feb 29, 2024
@yp05327
Copy link
Contributor

yp05327 commented Feb 29, 2024

Didn't link the issue correctly.
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

@charles7668
Copy link
Contributor Author

Didn't link the issue correctly. https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

Fixed

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 29, 2024
yp05327
yp05327 reviewed Feb 29, 2024
View reviewed changes
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 29, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 2, 2024
@lunny lunny enabled auto-merge (squash) March 2, 2024 08:44
@lunny lunny merged commit 9043584 into go-gitea:main Mar 2, 2024
@GiteaBot GiteaBot added this to the 1.22.0 milestone Mar 2, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Mar 2, 2024
@charles7668 @GiteaBot
Fix issue link does not support quotes (go-gitea#29484) (go-gitea#29487)
b44e000 
Close go-gitea#29484

![圖片](https://github.com/go-gitea/gitea/assets/30816317/b27e6e16-67e0-469c-8e04-30180c585890)
@GiteaBot GiteaBot mentioned this pull request Mar 2, 2024
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Mar 2, 2024
lunny pushed a commit that referenced this pull request Mar 2, 2024
@GiteaBot @charles7668
Fix issue link does not support quotes (#29484) (#29487) (#29536)
3a8877c 
Backport #29487 by @charles7668

Close #29484

![圖片](https://github.com/go-gitea/gitea/assets/30816317/b27e6e16-67e0-469c-8e04-30180c585890)

Co-authored-by: charles <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 2, 2024
@zjjhot
Merge remote-tracking branch 'upstream/main'
768e1ba 
* upstream/main:
  Fix a bug returning 404 when display a single tag with no release (go-gitea#29466)
  Add a check for when the command is canceled by the program on Window… (go-gitea#29538)
  Fix incorrect redirection when creating a PR fails (go-gitea#29537)
  Fix incorrect subpath in links (go-gitea#29535)
  Fix issue link does not support quotes (go-gitea#29484) (go-gitea#29487)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2024
@charles7668 charles7668 deleted the FixIssueLink branch April 10, 2024 01:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@yp05327 yp05327 yp05327 left review comments

@delvh delvh delvh approved these changes

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.22.0

Development

Successfully merging this pull request may close these issues.

alphanumeric issue matching not working with quotes around issue

5 participants

@charles7668 @lunny @yp05327 @delvh @GiteaBot