Skip to content

Conversation

cez81
Copy link
Contributor

@cez81 cez81 commented Nov 26, 2017

I messed something up during the last rebase of #1522, PR should have been conf/app.ini -> custom/conf/app.ini.sample

Fixes faulty PR #1522.

@lunny
Copy link
Member

lunny commented Nov 26, 2017

indeed. LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 26, 2017
@lunny lunny added this to the 1.4.0 milestone Nov 26, 2017
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@7091db8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #2977   +/-   ##
========================================
  Coverage          ?   26.8%           
========================================
  Files             ?      90           
  Lines             ?   17810           
  Branches          ?       0           
========================================
  Hits              ?    4774           
  Misses            ?   12355           
  Partials          ?     681

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7091db8...f1f3ac7. Read the comment docs.

@lafriks
Copy link
Member

lafriks commented Nov 26, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 26, 2017
@lafriks lafriks merged commit 4d85c1d into go-gitea:master Nov 26, 2017
@cez81 cez81 deleted the app.ini branch November 26, 2017 16:34
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants