Skip to content

Add result check in TestAPIEditUser (#29674) #30860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2024

Conversation

GiteaBot
Copy link
Collaborator

@GiteaBot GiteaBot commented May 5, 2024

Backport #29674 by @yp05327

Fix #29514
there are too many usage of NewRequestWithValues, so there's no need to check all of them.
Just one is enough I think.

Fix go-gitea#29514
There are too many usage of `NewRequestWithValues`, so there's no need
to check all of them.
Just one is enough I think.
@GiteaBot GiteaBot added modifies/go Pull requests that update Go code skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/testing labels May 5, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 5, 2024
@GiteaBot GiteaBot added this to the 1.22.0 milestone May 5, 2024
@GiteaBot GiteaBot requested review from lunny and yardenshoham May 5, 2024 02:10
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 5, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 5, 2024
@lunny lunny merged commit 0546029 into go-gitea:release/v1.22 May 5, 2024
26 checks passed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants