Skip to content

Add tag protection via rest api #17862 #31295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 14, 2024
Merged

Add tag protection via rest api #17862 #31295

merged 6 commits into from
Jun 14, 2024

Conversation

mzroot
Copy link
Contributor

@mzroot mzroot commented Jun 8, 2024

Add tag protection manage via rest API.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 8, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Jun 8, 2024
@mzroot mzroot force-pushed the api_tag_protections branch from 32c7a35 to 6c30c98 Compare June 13, 2024 07:17
@mzroot mzroot requested a review from silverwind June 13, 2024 07:27
@mzroot mzroot force-pushed the api_tag_protections branch from db2a2d3 to 51c0a1b Compare June 13, 2024 07:42
silverwind
silverwind approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, the only thing I would have liked to change is the whitelist term, but this is consistent with existing configs etc, so can not be changed in a non-breaking fashion.

Someone with more backend expertise should have a look too.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 13, 2024
@lunny lunny added this to the 1.23.0 milestone Jun 13, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 14, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 14, 2024
@silverwind silverwind merged commit d4e4226 into go-gitea:main Jun 14, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 14, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 16, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
54fe6ea 
* giteaofficial/main:
  Fix JS error when creating new issue (go-gitea#31383)
  [skip ci] Updated translations via Crowdin
  Rename repo_model.SearchOrderByMap to repo_model.OrderByMap (go-gitea#31359)
  rm const do inline (go-gitea#31360)
  Allow downloading attachments of draft releases (go-gitea#31369)
  Fix duplicate sub-path for avatars (go-gitea#31365)
  [skip ci] Updated translations via Crowdin
  Add tag protection via rest api go-gitea#17862 (go-gitea#31295)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mzroot @lunny @silverwind @GiteaBot