Skip to content

Fix line number widths (#31341) #31343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Fix line number widths (#31341) #31343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
222b830
Fix line number widths (#31341)
silverwind Jun 12, 2024
0b8ee4a
Merge branch 'release/v1.22' into backport-31341-v1.22
wxiaoguang Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions web_src/css/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1005,6 +1005,13 @@ overflow-menu .ui.label {
padding: 0 8px;
text-align: right !important;
color: var(--color-text-light-2);
width: 1%; /* this apparently needs to be a percentage so that code column stretches in diffs */
min-width: 72px;
white-space: nowrap;
}

.code-diff .lines-num {
min-width: 50px;
}

.lines-num span.bottom-line::after {
Expand All @@ -1024,6 +1031,7 @@ overflow-menu .ui.label {

.lines-type-marker {
vertical-align: top;
white-space: nowrap;
}

.lines-num,
Expand Down Expand Up @@ -1056,6 +1064,7 @@ overflow-menu .ui.label {

.lines-escape {
width: 0;
white-space: nowrap;
}

.lines-code {
Expand Down
8 changes: 0 additions & 8 deletions web_src/css/repo.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1555,8 +1555,6 @@ td .commit-summary {

.repository .diff-file-box .file-body.file-code .lines-num {
text-align: right;
width: 1%;
min-width: 50px;
}

.repository .diff-file-box .file-body.file-code .lines-num span.fold {
Expand All @@ -1582,12 +1580,6 @@ td .commit-summary {
table-layout: fixed;
}

.repository .diff-file-box .code-diff tbody tr td.lines-num,
.repository .diff-file-box .code-diff tbody tr td.lines-escape,
.repository .diff-file-box .code-diff tbody tr td.lines-type-marker {
white-space: nowrap;
}

.repository .diff-file-box .code-diff tbody tr td.center {
text-align: center;
}
Expand Down