Skip to content

Fix wrong Reviewed-on rendering in PR #31366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ExplodingDragon
Copy link
Contributor

@ExplodingDragon ExplodingDragon commented Jun 14, 2024

Related #31211

Before:
img

After:
img

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 14, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jun 14, 2024
@ExplodingDragon
Copy link
Contributor Author

current PR has been included in #31365

@ExplodingDragon ExplodingDragon deleted the bugfix-reviewed-on branch June 14, 2024 03:26
@ExplodingDragon ExplodingDragon restored the bugfix-reviewed-on branch June 14, 2024 03:26
@ExplodingDragon ExplodingDragon deleted the bugfix-reviewed-on branch June 14, 2024 03:26
@wxiaoguang
Copy link
Contributor

Thank you for figuring out the problem. I added you as Co-authored-by in #31365 🙏

wxiaoguang added a commit that referenced this pull request Jun 15, 2024
Fix #31361, and add tests

And this PR introduces an undocumented & debug-purpose-only config
option: `USE_SUB_URL_PATH`. It does nothing for end users, it only helps
the development of sub-path related problems.

And also fix #31366

Co-authored-by: @ExplodingDragon
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants