Skip to content

Improve log format #33814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 8, 2025
Merged

Improve log format #33814

merged 3 commits into from
Mar 8, 2025

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Mar 6, 2025 •
edited
Loading

Old:

2025/03/06 22:21:06 ...er/issues/indexer.go:76:func1() [I] PID 88713: Initializing Issue Indexer: bleve
2025/03/06 22:21:12 ...eb/routing/logger.go:102:func1() [I] router: completed GET / for [::1]:52693, 200 OK in 15.9ms @ web/home.go:32(web.Home)

New:

2025/03/06 22:20:20 .../indexer/issues/indexer.go:76:InitIssueIndexer.1() [I] PID 88595: Initializing Issue Indexer: bleve
2025/03/06 22:20:35 HTTPRequest [I] router: completed GET / for [::1]:52631, 200 OK in 7.5ms @ web/home.go:32(web.Home)

⚠️ BREAKING ⚠️

Actually it isn't really breaking for most users.

If some users use some filters (regexp) to parse the log output, please make the filters work with the new log format.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 6, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Mar 6, 2025
@wxiaoguang wxiaoguang added the type/enhancement An improvement of existing functionality label Mar 6, 2025
@wxiaoguang wxiaoguang force-pushed the fix-log branch 2 times, most recently from 9d7f782 to f7670be Compare March 6, 2025 14:32
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 6, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 8, 2025
@wxiaoguang wxiaoguang merged commit 4ed71eb into go-gitea:main Mar 8, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Mar 8, 2025
@wxiaoguang wxiaoguang deleted the fix-log branch March 8, 2025 13:47
@wxiaoguang wxiaoguang added the pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! label Mar 8, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 10, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
7aa16d2 
* giteaofficial/main:
  Move notifywatch to service layer (go-gitea#33825)
  [skip ci] Updated translations via Crowdin
  Only keep popular licenses (go-gitea#33832)
  Removing unwanted ui container (go-gitea#33833)
  Full-file syntax highlighting for diff pages (go-gitea#33766)
  Improve theme display (go-gitea#30671)
  Decouple context from repository related structs (go-gitea#33823)
  Improve log format (go-gitea#33814)
  Decouple diff stats query from actual diffing (go-gitea#33810)
  Add global lock for migrations to make upgrade more safe with multiple replications (go-gitea#33706)
  Do not show passkey on http sites (go-gitea#33820)
hiifong pushed a commit to hiifong/gitea that referenced this pull request Mar 10, 2025
@wxiaoguang @hiifong
Improve log format (go-gitea#33814)
816113a 
(cherry picked from commit 4ed71eb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@hiifong hiifong hiifong approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @hiifong @GiteaBot