Skip to content

Fix material icon & diff highlight #33844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 10, 2025
Merged

Fix material icon & diff highlight #33844

merged 2 commits into from
Mar 10, 2025

Conversation

wxiaoguang
Copy link
Contributor

No description provided.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 10, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Mar 10, 2025
@wxiaoguang
Copy link
Contributor Author

Before:

  • Some files like "php" were not recognized by the material icon rules.
  • The full-file diff highlight is not quite right

After:

image

image

image

image

This was referenced Mar 10, 2025
Merged
Merged
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Mar 10, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Mar 10, 2025
@wxiaoguang wxiaoguang force-pushed the fix-icon-highlight branch 2 times, most recently from f3a1752 to 4697a79 Compare March 10, 2025 12:49
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 10, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 10, 2025
@wxiaoguang wxiaoguang merged commit 657239b into go-gitea:main Mar 10, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the fix-icon-highlight branch March 10, 2025 14:35
hiifong pushed a commit to hiifong/gitea that referenced this pull request Mar 10, 2025
@wxiaoguang @hiifong
Fix material icon & diff highlight (go-gitea#33844)
cb0f865 
(cherry picked from commit 657239b)
@wxiaoguang
Copy link
Contributor Author

Next: Fix file icon mapping #33855

zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 12, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
62e84f3 
* giteaofficial/main:
  Fix various Fomantic UI and htmx problems (go-gitea#33851)
  Add workflow_job webhook (go-gitea#33694)
  Fix file icon mapping (go-gitea#33855)
  Drop fomantic build (go-gitea#33845)
  Fix auto concurrency cancellation skips commit status updates (go-gitea#33764)
  Fix test code (go-gitea#33829)
  Remove "noscript" tag from html head (go-gitea#33846)
  Fix material icon & diff highlight (go-gitea#33844)
  Fix LFS URL (go-gitea#33840)
  Add material icons for file list (go-gitea#33837)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yardenshoham yardenshoham yardenshoham approved these changes

@hiifong hiifong hiifong approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @yardenshoham @hiifong @GiteaBot