Skip to content

Replace update repository function in some places #34566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Replace update repository function in some places #34566

wants to merge 8 commits into from
+121 −57

Conversation

lunny
Copy link
Member

@lunny lunny commented May 30, 2025 •
edited
Loading

UpdateAllCols is dangerous, the columns should be updated when necessary.

This PR replaces some updateRepository invokes to reduce possible problems and wrongly updated time. Some parts have been fixed in #34388, but some are hidden in the function updateRepository. Alternatively, using UpdateRepositoryColsNoAutoTime to update the changed columns.

Some UpdateRepoSize invokes are duplicated, so they will be removed when extracting from updateRepository.

PS: I suspect #27472 is related. The num_pulls is not right in the database.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label May 30, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 30, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label May 30, 2025
@lunny lunny marked this pull request as ready for review May 30, 2025 20:37
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 9, 2025
@yp05327 yp05327 changed the title replace update repository function in some places Replace update repository function in some places Jun 10, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 17, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appleboy appleboy appleboy approved these changes

@yp05327 yp05327 yp05327 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @appleboy @yp05327 @GiteaBot