Skip to content

Conversation

wxiaoguang
Copy link
Contributor

Fix #35126

The "go-chi/session" package is problematic for handling structs.

The old test code was not able to catch the abuses either.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 19, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jul 19, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 19, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 19, 2025
@lunny lunny added type/bug reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Jul 19, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) July 20, 2025 01:23
@wxiaoguang wxiaoguang merged commit 86aafea into go-gitea:main Jul 20, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.25.0 milestone Jul 20, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 20, 2025
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jul 20, 2025
@wxiaoguang wxiaoguang deleted the fix-oauth2-session branch July 20, 2025 01:59
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 22, 2025
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Fix session gob (go-gitea#35128)
  Replace `setup-python` with `setup-uv` (go-gitea#35116)
  Don't use full-file highlight when there is a git diff textconv (go-gitea#35114)
  Fix submodule parsing when the gitmodules is missing (go-gitea#35109)
  Align `issue-title-buttons` with `list-header` (go-gitea#35018)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PANIC type not registered for interface: oauth2.Source
4 participants