Skip to content

Conversation

na-Itms
Copy link
Contributor

@na-Itms na-Itms commented Aug 2, 2025

Fixes #34634


I am not a Web dev so I'm open to any change on the design. The important thing for me is to have the feature implemented.

Here are screenshots on a test instance:

Capture d'écran 2025-08-02 161710 Capture d'écran 2025-08-02 161725

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 2, 2025
@github-actions github-actions bot added modifies/translation modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Aug 2, 2025
@lunny lunny added this to the 1.25.0 milestone Aug 2, 2025
@lunny lunny added the type/enhancement An improvement of existing functionality label Aug 2, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 3, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 3, 2025
@wxiaoguang wxiaoguang marked this pull request as draft August 4, 2025 03:19
@na-Itms na-Itms force-pushed the display-merged-commit-pr branch from bb114a4 to b6f6aed Compare August 4, 2025 08:29
@na-Itms na-Itms marked this pull request as ready for review August 4, 2025 08:29
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 4, 2025
@lunny lunny enabled auto-merge (squash) August 4, 2025 23:09
@lunny lunny merged commit c760e3b into go-gitea:main Aug 4, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 4, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 5, 2025
* giteaofficial/main:
  Fix Actions API (go-gitea#35204)
  Add webhook test for push event (go-gitea#34442)
  Remove unneeded if statements for `update repo` API  (go-gitea#35140)
  [skip ci] Updated translations via Crowdin
  Step down as maintainer (justusbunsi) (go-gitea#35212)
  Display pull request in merged commit view (go-gitea#35202)
  Step down as maintainer (pat-s) (go-gitea#35213)
@na-Itms
Copy link
Contributor Author

na-Itms commented Aug 5, 2025

@lunny Thanks for merging! Given the small size of the feature, would it be acceptable to uplift this to the 1.24 branch?

Also, I would like to mention that the PR template says Your input here will be included in the commit message when this PR has been merged. If you don't want some content to be included, please separate them with a line like ---, but my comment above about not being a web dev ended up in the commit message! 😬

@lunny
Copy link
Member

lunny commented Aug 5, 2025

Sorry for the mistakenly added content in your pull request message. I believe the screenshots should be part of the commit message, not the pull request note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/translation type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The commit view should display the PR it was merged in
5 participants