Skip to content

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented May 12, 2018

Fixes #3944

@lafriks lafriks added the type/enhancement An improvement of existing functionality label May 12, 2018
@lafriks lafriks added this to the 1.5.0 milestone May 12, 2018
@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 12, 2018
@codecov-io
Copy link

codecov-io commented May 12, 2018

Codecov Report

Merging #3955 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3955   +/-   ##
=======================================
  Coverage   20.26%   20.26%           
=======================================
  Files         146      146           
  Lines       29319    29319           
=======================================
  Hits         5942     5942           
  Misses      22475    22475           
  Partials      902      902

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c34ef5...fec35d0. Read the comment docs.

@lunny
Copy link
Member

lunny commented May 13, 2018

LGTM

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 13, 2018
@appleboy appleboy merged commit e740558 into go-gitea:master May 13, 2018
@lafriks lafriks deleted the fix/oauth_mysql_driver branch May 13, 2018 10:59
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oauth2 don't fly with mysql/mariadb
6 participants