Skip to content

Delete reactions added to issues and comments when deleting repository #4232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 12, 2018
Merged

Delete reactions added to issues and comments when deleting repository #4232

merged 3 commits into from
Jun 12, 2018

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Jun 12, 2018

As title

@lafriks lafriks added this to the 1.5.0 milestone Jun 12, 2018
@codecov-io
Copy link

codecov-io commented Jun 12, 2018 •
edited
Loading

Codecov Report

Merging #4232 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4232      +/-   ##
==========================================
+ Coverage   19.95%   19.96%   +<.01%     
==========================================
  Files         153      153              
  Lines       30518    30521       +3     
==========================================
+ Hits         6091     6094       +3     
- Misses      23512    23513       +1     
+ Partials      915      914       -1
Impacted Files Coverage Δ
models/repo.go 17.82% <0%> (-0.04%) ⬇️
modules/process/manager.go 73.91% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 406031d...752b66e. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 12, 2018
@lunny
Copy link
Member

lunny commented Jun 12, 2018

LGTM

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 12, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 12, 2018
@techknowlogick techknowlogick merged commit 2b8c0bb into go-gitea:master Jun 12, 2018
@techknowlogick
Copy link
Member

@lafriks does this need a backport?

@lafriks lafriks deleted the fix/delete_repo_reactions branch June 12, 2018 21:12
@lafriks
Copy link
Member Author

lafriks commented Jun 12, 2018

I can create one probably

@lafriks lafriks added backport/v1.4 backport/done All backports for this PR have been created labels Jun 12, 2018
lafriks added a commit to lafriks-fork/gitea that referenced this pull request Jun 12, 2018
@lafriks
Delete reactions added to issues and comments when deleting repository (
b9f8641 
go-gitea#4232)
@lafriks lafriks mentioned this pull request Jun 12, 2018
Merged
techknowlogick pushed a commit that referenced this pull request Jun 12, 2018
@lafriks @techknowlogick
Delete reactions added to issues and comments when deleting repository (
c746f82 
#4232) (#4237)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@sapk sapk sapk approved these changes

@jonasfranz jonasfranz jonasfranz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
7 participants
@lafriks @codecov-io @lunny @techknowlogick @sapk @jonasfranz @bkcsoft