Skip to content

README: update make command to build full release #5004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2018
Merged

README: update make command to build full release #5004

merged 2 commits into from
Oct 3, 2018

Conversation

coolaj86
Copy link
Contributor

@coolaj86 coolaj86 commented Oct 3, 2018

make generate all => TAGS=bindata make generate all

@codecov-io
Copy link

codecov-io commented Oct 3, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@2e2eacf). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5004   +/-   ##
=========================================
  Coverage          ?   37.41%           
=========================================
  Files             ?      306           
  Lines             ?    45374           
  Branches          ?        0           
=========================================
  Hits              ?    16975           
  Misses            ?    25946           
  Partials          ?     2453

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e2eacf...4940203. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 3, 2018
techknowlogick
techknowlogick reviewed Oct 3, 2018
View reviewed changes
@techknowlogick techknowlogick added the type/docs This PR mainly updates/creates documentation label Oct 3, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 3, 2018
lafriks
lafriks requested changes Oct 3, 2018
View reviewed changes
use quoted TAGS
4940203 
`TAGS=bindata` => `TAGS="bindata"`
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 3, 2018
@jonasfranz jonasfranz merged commit 2b8dc17 into go-gitea:master Oct 3, 2018
@coolaj86 coolaj86 deleted the patch-3 branch October 3, 2018 06:34
@lafriks
Copy link
Member

lafriks commented Oct 3, 2018

It's not that I would mind much that this was merged but please wait till all change requests are approved before merging :)

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks requested changes

@techknowlogick techknowlogick techknowlogick approved these changes

+1 more reviewer

@jonasfranz jonasfranz jonasfranz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@coolaj86 @codecov-io @lafriks @techknowlogick @jonasfranz @bkcsoft