Skip to content

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented May 5, 2019

This PR adds Migration tests for MSSQL.

It will fail at present due to the bug in v78.go and therefore requires #6823

It will also fail at present because of a bug in v85.go and requires #6851

@zeripath
Copy link
Contributor Author

zeripath commented May 5, 2019

This could be backported to 1.8 easily once #6823 is merged and backported as #6727 has already been backported.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 5, 2019
@lunny lunny added this to the 1.9.0 milestone May 5, 2019
@zeripath
Copy link
Contributor Author

zeripath commented May 5, 2019

Also requires #6823

@zeripath zeripath changed the title Add mssql migration tests Add mssql migration tests (needs #6823) May 5, 2019
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@722a2bd). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6852   +/-   ##
=========================================
  Coverage          ?   41.14%           
=========================================
  Files             ?      425           
  Lines             ?    58484           
  Branches          ?        0           
=========================================
  Hits              ?    24061           
  Misses            ?    31238           
  Partials          ?     3185
Impacted Files Coverage Δ
models/migrations/migrations.go 1.52% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 722a2bd...2337f3b. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 5, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 5, 2019
@lafriks lafriks merged commit 0081cd8 into go-gitea:master May 5, 2019
@zeripath zeripath deleted the mssql-migration-tests branch May 5, 2019 23:43
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants