-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Make webhook http connections resuable #6976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make webhook http connections resuable #6976
Conversation
ce068b1
to
b293feb
Compare
Codecov Report
@@ Coverage Diff @@
## master #6976 +/- ##
=========================================
+ Coverage 41.45% 41.5% +0.04%
=========================================
Files 441 440 -1
Lines 59699 59453 -246
=========================================
- Hits 24747 24673 -74
+ Misses 31727 31560 -167
+ Partials 3225 3220 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although it appears that at present we only have a single threaded user of the webhook client in deliver it might be better to make a pool and get/release.
Otherwise looks good
* make http connections resuable * add error handler * fix lint
The
httplib
will always create a newhttp.Client
. That's no problem when there are few webhooks sent. But when you have hundreds of thousand webhooks to be sent, it will never reuse http connections. So let's keep only onehttp.Client
for webhooks.