Use vendors when go generate #7340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
topic/build
GiteaBot
added
the
lgtm/need 2
|
@techknowlogick Maybe we should do that on v1.10, I will move this to v1.10 so that we could not change the minimal Golang requirement on v1.9. |
Codecov Report
@@ Coverage Diff @@
## master #7340 +/- ##
==========================================
+ Coverage 41.23% 41.23% +<.01%
==========================================
Files 468 468
Lines 63337 63337
==========================================
+ Hits 26114 26116 +2
- Misses 33812 33813 +1
+ Partials 3411 3408 -3
Continue to review full report at Codecov.
|
jeffliu27
pushed a commit
to jeffliu27/gitea
that referenced
this pull request
Jul 18, 2019
* use vendors when go generate * update docs about golang minimal requirement from 1.9 to 1.11 * fix build
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have store all the dependencies on vendor, I think we should also use them when run
go generate. This will speed upmake generateprocess and reduce failure possible when CI runs.