Fix 'Diff stats' scroll error #7535
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the 'Show diff stats' window is open, if longer than the screen, the sticky element does not scroll and hides the diff files in the background. Fixes #5532
Codecov Report
@@ Coverage Diff @@
## master #7535 +/- ##
==========================================
+ Coverage 41.23% 41.24% +0.01%
==========================================
Files 469 469
Lines 63620 63620
==========================================
+ Hits 26232 26241 +9
+ Misses 33965 33956 -9
Partials 3423 3423
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
lafriks
approved these changes
Jul 19, 2019
GiteaBot
added
lgtm/need 1
|
Any screenshots? |
|
See #5532 |
silverwind
reviewed
Jul 21, 2019
Rather than removing sticky, add to the bare <div> element so that diff actions are sticky.
|
@silverwind agreed, updated to mirror Github style (Review button sticky) |
|
Why close? |
|
There is also some JS affecting this element. Looking into it but out of scope for this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the 'Show diff stats' window is open, if the diff stats container is longer than the viewport, the sticky element does not scroll and hides the diff files in the background, although they continue to scroll.
Removed sticky class.
Fixes #5532