Skip to content

Conversation

6543
Copy link
Member

@6543 6543 commented Jul 24, 2019

part of PR #7520
and issue #7454

@codecov-io
Copy link

Codecov Report

Merging #7603 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7603      +/-   ##
==========================================
- Coverage   41.24%   41.24%   -0.01%     
==========================================
  Files         469      469              
  Lines       63608    63608              
==========================================
- Hits        26236    26232       -4     
- Misses      33952    33957       +5     
+ Partials     3420     3419       -1
Impacted Files Coverage Δ
models/unit.go 62.16% <0%> (-5.41%) ⬇️
routers/repo/view.go 42.23% <0%> (-1.02%) ⬇️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4667a4...f2776dc. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 24, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 25, 2019
@zeripath
Copy link
Contributor

zeripath commented Jul 25, 2019

This change does not really warrant classing as a PR.

Surely this could be folded into a different PR?

@6543
Copy link
Member Author

6543 commented Jul 25, 2019

@zeripath i can add it to #7602 or the once wich will folow?
or look at more parts i the code wich are to reformat befor merging?
(I like working in code wich is formated properly (especialy Code Indentation)) :D

@zeripath
Copy link
Contributor

Oh I agree about having good code formatting but I think you're changing all the lines nearby this in another pr - so just put it there. Small formatting PRs are just noise.

@6543
Copy link
Member Author

6543 commented Jul 26, 2019

-> #7622

@6543 6543 closed this Jul 26, 2019
@6543 6543 deleted the branch-view-code-format branch July 26, 2019 00:29
@6543 6543 restored the branch-view-code-format branch July 26, 2019 02:12
@6543 6543 reopened this Jul 26, 2019
@6543 6543 closed this Jul 26, 2019
@6543 6543 deleted the branch-view-code-format branch July 27, 2019 13:38
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants