Skip to content

Conversation

6543
Copy link
Member

@6543 6543 commented Oct 14, 2019

finaly ;)

@6543 6543 force-pushed the changelog-1.10.0 branch from aff6bca to df42d3b Compare October 14, 2019 15:44
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 14, 2019
Copy link
Member

@jolheiser jolheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be an RC first?

Co-Authored-By: John Olheiser <[email protected]>
@codecov-io
Copy link

codecov-io commented Oct 14, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@8c8a93c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8510   +/-   ##
=========================================
  Coverage          ?   41.71%           
=========================================
  Files             ?      512           
  Lines             ?    66941           
  Branches          ?        0           
=========================================
  Hits              ?    27922           
  Misses            ?    35432           
  Partials          ?     3587

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c8a93c...5784087. Read the comment docs.

@lafriks lafriks added the type/docs This PR mainly updates/creates documentation label Oct 14, 2019
@lafriks lafriks added this to the 1.10.0 milestone Oct 14, 2019
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind the Testing, Build and Docs sections remaining - but equally they could be removed.

@GiteaBot GiteaBot removed the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 14, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 14, 2019
@6543 6543 changed the title Changelog for 1.10.0 Changelog for 1.10.0-RC1 Oct 14, 2019
Copy link
Member Author

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ready if you are?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 14, 2019
@6543
Copy link
Member Author

6543 commented Oct 14, 2019

ready 🚀

@zeripath zeripath merged commit db0d4ff into go-gitea:master Oct 14, 2019
@6543 6543 deleted the changelog-1.10.0 branch October 14, 2019 19:50
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants