Skip to content

Allow incompletely specified Time Formats #8816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 8, 2019
Merged

Allow incompletely specified Time Formats #8816

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
77c408a
Allow incompletely specified time formats
zeripath Nov 3, 2019
43bf927
Adjust error reporting slightly
zeripath Nov 3, 2019
c8efff0
Update setting.go
zeripath Nov 3, 2019
0738ac4
Merge branch 'master' into fix-7927
techknowlogick Dec 8, 2019
917e61d
Merge branch 'master' into fix-7927
techknowlogick Dec 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion modules/setting/setting.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -835,7 +835,8 @@ func NewContext() {
TimeFormat = timeFormatKey
TestTimeFormat, _ := time.Parse(TimeFormat, TimeFormat)
if TestTimeFormat.Format(time.RFC3339) != "2006-01-02T15:04:05Z" {
log.Fatal("Can't create time properly, please check your time format has 2006, 01, 02, 15, 04 and 05")
log.Warn("Provided TimeFormat: %s does not create a fully specified date and time.", TimeFormat)
log.Warn("In order to display dates and times correctly please check your time format has 2006, 01, 02, 15, 04 and 05")
}
log.Trace("Custom TimeFormat: %s", TimeFormat)
}
Expand Down