Skip to content

Conversation

nztim
Copy link
Contributor

@nztim nztim commented Dec 20, 2019

This PR originates from #9366. It might be helpful to include something in the docs to make it as easy as possible to implement SSL.

In this PR I simply added a note but you could alternatively add the line to the actual config block with a comment, have a separate section/page going into more detail, or achieve it another way.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 20, 2019
@codecov-io
Copy link

codecov-io commented Dec 20, 2019

Codecov Report

Merging #9438 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9438      +/-   ##
==========================================
- Coverage    41.5%   41.49%   -0.01%     
==========================================
  Files         570      570              
  Lines       74324    74328       +4     
==========================================
- Hits        30847    30844       -3     
- Misses      39636    39642       +6     
- Partials     3841     3842       +1
Impacted Files Coverage Δ
routers/init.go 67.81% <50%> (-0.86%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
models/pull.go 52.91% <0%> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10169ef...1593781. Read the comment docs.

@lunny lunny added the type/docs This PR mainly updates/creates documentation label Dec 20, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 20, 2019
@lafriks lafriks merged commit f8a6eb8 into go-gitea:master Dec 20, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants