Migrate to github.com/go-viper/mapstructure/v2 #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The github.com/mitchellh/mapstructure package is archived and no longer receives updates[^1]. The "blessed" fork[^2] is github.com/go-viper/mapstructure. The API is the same, so nothing needs to be changed apart from the import path. [^1]: mitchellh/mapstructure#349 [^2]: https://gist.github.com/mitchellh/90029601268e59a29e64e55bab1c5bdc Signed-off-by: Tobias Klauser <[email protected]>
|
Thanks. If I remember correctly we have this dependency in other repos for go-openapi and go-swagger. Have to check |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #157 +/- ##
=======================================
Coverage 82.87% 82.87%
=======================================
Files 13 13
Lines 2178 2178
=======================================
Hits 1805 1805
Misses 295 295
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fredbi
approved these changes
Apr 10, 2025
The only other use I could find in these projects (according to https://pkg.go.dev/github.com/mitchellh/mapstructure?tab=importedby) was in github.com/go-swagger/go-swagger. Opened go-swagger/go-swagger#3186 to migrate the package there as well. |
dolmen
added a commit
to dolmen-go/haproxytech.client-native.fork
that referenced
this pull request
May 15, 2025
Replace github.com/mitchellh/mapstructure with github.com/go-viper/mapstructure/v2. Rationale: Module github.com/mitchellh/mapstructure isn't supported anymore. Announcement: https://gist.github.com/mitchellh/90029601268e59a29e64e55bab1c5bdc The blessed fork is at github.com/go-viper/mapstructure/v2. Note: github.com/mitchellh/mapstructure is still referenced in dependencies of go-openapi packages, but this is already being fixed (see go-openapi/strfmt#157 ) and will be released with the next github.com/go-openapi/strfmt. Signed-off-by: Olivier Mengué <[email protected]>
mjuraga
pushed a commit
to haproxytech/client-native
that referenced
this pull request
May 15, 2025
Replace github.com/mitchellh/mapstructure with github.com/go-viper/mapstructure/v2. Rationale: Module github.com/mitchellh/mapstructure isn't supported anymore. Announcement: https://gist.github.com/mitchellh/90029601268e59a29e64e55bab1c5bdc The blessed fork is at github.com/go-viper/mapstructure/v2. Note: github.com/mitchellh/mapstructure is still referenced in dependencies of go-openapi packages, but this is already being fixed (see go-openapi/strfmt#157 ) and will be released with the next github.com/go-openapi/strfmt. Signed-off-by: Olivier Mengué <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The github.com/mitchellh/mapstructure package is archived and no longer receives updates1. The "blessed" fork2 is
github.com/go-viper/mapstructure. The API is the same, so nothing needs to be changed apart from the import path.
Footnotes
https://github.com/mitchellh/mapstructure/issues/349 ↩
https://gist.github.com/mitchellh/90029601268e59a29e64e55bab1c5bdc ↩