Skip to content

Each function passes the correct value or pointer to rules. #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −1
Open

Each function passes the correct value or pointer to rules. #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion each.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ func (r EachRule) getInterface(value reflect.Value) interface{} {
if value.IsNil() {
return nil
}
return value.Elem().Interface()
return value.Interface()
default:
return value.Interface()
}
Expand Down
13 changes: 13 additions & 0 deletions each_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,3 +72,16 @@ func TestEachWithContext(t *testing.T) {
assertError(t, test.err, err, test.tag)
}
}

func TestEachAndBy(t *testing.T) {
var byAddr bool
var s string
Each(By(func(v interface{}) error {
_, byAddr = v.(*string)
return nil
})).Validate([]*string{&s})

if !byAddr {
t.Fatal("slice of pointers does not get passed to `By` function by ref")
}
}