-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Regex support #1239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
One of the unfortunate things here is that this will only allow top level validation using regex. One of the more useful regex use-cases that I can think of is validating a map's keys and or values to match a specific regex pattern. That said, I personally disagree with the lack of regex validators in general and think there should at-least be some way to use regex. I suspect an un-reasonably large chunk of users of this library have added their own regex validator implementations (myself included). |
Hey all, it seems like that this has come back around and more people are requesting regex support again and so feel the need to comment about why it doesn't exists in the base package and also why it likely continue to remain as-is.
I might be missing more but have to start my day and think that's enough to demonstrate why it doesn't exist today and likely won't be added. I know a lot of people would like it and reach for regexes regularly but I'm truly trying trying to help by not adding it because of the above reasons for both people and this packages sake. |
Uh oh!
There was an error while loading. Please reload this page.
Enhancement:
Why dont you add a new
regexp
tag like soI know that it won’t be possible to add support for regexp inside the
validate
tag and maybe this is against the design, but regexp is also a basic tool that everyone needs.The text was updated successfully, but these errors were encountered: