Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow the Limiter to be optionally configured with a key prefix. This makes the limiter more flexible as not all applications need to be prefixed with
rate:
.Using the
Options
pattern ensures we do not break backwards compatibility and will still use the default value.Users of this package can chose to:
WithKeyPrefix
when initializing the limiter to use the default value ofrate:
WithKeyPrefix("")
to remove all prefixes from the used keys.I extended the
TestAllow
to use different key prefixes. I don't think it's necessary to extend the other tests as this already shows things work as expected.For extra context, we are looking at using this package for https://gitlab.com/gitlab-org/container-registry, however this is a current limitation we have given our guidelines.