Skip to content

feat: process variables in include vars #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 5, 2025
Merged

feat: process variables in include vars #2113

merged 2 commits into from
Apr 5, 2025

Conversation

pd93
Copy link
Member

@pd93 pd93 commented Mar 11, 2025

Fixes #2108

Including a Taskfile with a static variable works:

version: 3

includes:
  bar:
    taskfile: included.yaml
    vars:
      FOOBAR: foo

However, if you want to use an existing variable when including a Taskfile:

version: 3

vars:
  FOOBAR: foo

includes:
  bar:
    taskfile: included.yaml
    vars:
      FOOBAR: "{{.FOOBAR}}"

you're out of luck, since Task doesn't resolve variables in the include vars section. This PR adds that functionality.

@pd93 pd93 mentioned this pull request Mar 11, 2025
Open
@andreynering andreynering self-requested a review March 11, 2025 13:14
vmaerten
vmaerten approved these changes Apr 5, 2025
View reviewed changes
Copy link
Member

@vmaerten vmaerten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty straitforward

@pd93 pd93 merged commit f0414f1 into main Apr 5, 2025
14 checks passed
@pd93 pd93 deleted the 2108-process-variables-in-include-vars branch April 5, 2025 22:12
pd93 added a commit that referenced this pull request Apr 5, 2025
@pd93
chore: changelog for #2113
a9de239
@fechu fechu mentioned this pull request Apr 26, 2025
Closed
pd93 added a commit that referenced this pull request Apr 27, 2025
@pd93
Revert "feat: process variables in include vars (#2113)"
8162b05 
This reverts commit f0414f1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreynering andreynering andreynering approved these changes

@vmaerten vmaerten vmaerten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Variables from included Taskfiles cannot be overwritten
3 participants
@pd93 @andreynering @vmaerten