Implement static methods for engine + builtin classes #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The refcount was accidentally incremented on the Rust call-site, even though Godot already does that. Added regression test for this case.
Bromeon
added
feature
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 5, 2023
115: Implement static methods for class + builtin methods r=Bromeon a=Bromeon Also fixes a memory leak when `RefCounted` instances are returned from engine methods. Closes #43. Co-authored-by: Jan Haller <[email protected]>
Bromeon
changed the title
|
Build succeeded: |
ttencate
pushed a commit
to ttencate/gdext
that referenced
this pull request
Feb 5, 2023
115: Implement static methods for engine + builtin classes r=Bromeon a=Bromeon Also fixes a memory leak when `RefCounted` instances are returned from engine methods. Closes godot-rust#43. Co-authored-by: Jan Haller <[email protected]>
ttencate
pushed a commit
to ttencate/gdext
that referenced
this pull request
Feb 5, 2023
115: Implement static methods for engine + builtin classes r=Bromeon a=Bromeon Also fixes a memory leak when `RefCounted` instances are returned from engine methods. Closes godot-rust#43. Co-authored-by: Jan Haller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes a memory leak when
RefCountedinstances are returned from engine methods.Closes #43.